基本同意你的看法：

■你昨天見過以前來這兒的那個(gè)老師嗎？　　

Did you see the teacher who had come (been) here before yesterday?　　

■你以前見過昨天來這兒的那個(gè)老師嗎？　　

Have you seen the teacher who came here yesterday before?　　

■你見過以前來過這兒的那個(gè)老師嗎？　　

Have you seen the teacher who had come here before?　　

■你見過昨天來這兒的那個(gè)老師嗎？　　

Have you seen the teacher who came here yesterday?